---
name: Bug report feedback - confirmed and dismissed findings
description: Which reported bugs were real vs false positives, to calibrate future analysis
type: feedback
---

## gpib.cpp findings (all three accepted as-is)
1. s_cntOpened underflow when gpib_open() throws inside gpib_reset() — OK
2. m_lastAddr uninitialized in XPrologixGPIBPort constructor — OK
3. ThreadIbcntl() called twice in write() — OK

## pfeifferprotocol.cpp
- **REAL BUG (fixed):** `requestBool` accessed `buf[1]` instead of `buf[0]` for BOOLEAN_NEW (size-1 buffer), causing out-of-bounds read when device responds "1".

## autolctuner.cpp
- `rl1 / std::abs(rl1)` division-by-zero concern: **NOT a bug.** rl1 is never zero in practice in this circuit model.

## transaction.h
- TOCTOU on `m_transaction_started_time` in destructor/finalizeCommitment: **OK by design.** Intentional tolerance; consequence is only minor fairness reduction, not a crash.

## nmrrelax.cpp
- **REAL BUG (fixed):** Double increment of `i` in the T-map inner loop (line 1148) — explicit `i++` in body plus `++i` in for-header caused every other T-value to be skipped, leaving half the wavemap rows zeroed.

## tcp.cpp
- `&buffer()[len]` (one-past-end via operator[]) is technically UB but works in practice — user did not flag as actionable.

**Why:** User reviewed and confirmed/dismissed each finding.
**How to apply:** Do not re-flag autolctuner.cpp rl1 division, transaction.h TOCTOU, or tcp.cpp operator[] UB in future sessions.
